Skip to content

🔧 (repo) [NO-ISSUE]: Update toolchain#1332

Open
ldg-github-ci wants to merge 1 commit intodevelopfrom
chore/no-issue-update-toolchain
Open

🔧 (repo) [NO-ISSUE]: Update toolchain#1332
ldg-github-ci wants to merge 1 commit intodevelopfrom
chore/no-issue-update-toolchain

Conversation

@ldg-github-ci
Copy link

This PR updates the toolchain (node, npm, pnpm) to the newest versions and deduplicates packages

@ldg-github-ci ldg-github-ci requested a review from a team as a code owner March 1, 2026 00:49
Copilot AI review requested due to automatic review settings March 1, 2026 00:49
@vercel
Copy link

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
device-sdk-ts-sample Building Building Preview, Comment Mar 1, 2026 0:50am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
doc-device-management-kit Ignored Ignored Mar 1, 2026 0:50am

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository tooling versions (npm/pnpm) and refreshes the pnpm lockfile to reflect the new toolchain and deduplication outcomes.

Changes:

  • Bump npm and pnpm versions in .prototools
  • Update pnpm-lock.yaml (deduping/peer-resolution changes, notably around @types/node peer sets)

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
pnpm-lock.yaml Lockfile refresh/dedupe resulting in updated peer dependency resolutions and new deprecation metadata surfaced by pnpm.
.prototools Toolchain version bumps for npm and pnpm.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to +3
node = "20.20.0"
npm = "11.8.0"
pnpm = "10.28.2"
npm = "11.11.0"
pnpm = "10.30.3"
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.prototools bumps pnpm to 10.30.3, but the repo root package.json still declares "packageManager": "pnpm@10.28.2" (package.json:85). This is a discrepancy with the PR description/tooling and can cause contributors/CI to keep using the older pnpm. Please update package.json#packageManager to match the new pnpm version (or intentionally remove/avoid pinning, but keep it consistent with the toolchain automation).

Copilot uses AI. Check for mistakes.
Comment on lines 6643 to +6646
basic-ftp@5.0.4:
resolution: {integrity: sha512-8PzkB0arJFV4jJWSGOYR+OEic6aeKMu/osRhBULN6RY0ykby6LKhbmuQ5ublvaas5BOwboah5D87nrHyuh8PPA==}
engines: {node: '>=10.0.0'}
deprecated: Security vulnerability fixed in 5.2.0, please upgrade
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile now marks basic-ftp@5.0.4 as deprecated due to a security vulnerability fixed in 5.2.0. Since this version is still pulled in transitively (via get-uri@6.0.3 -> basic-ftp@5.0.4), please upgrade the dependency chain (e.g., bump get-uri/pac-proxy-agent to a version that depends on basic-ftp>=5.2.0) or add a pnpm override to force a patched basic-ftp version, so the repo isn’t shipping a known-vulnerable transitive dependency.

Suggested change
basic-ftp@5.0.4:
resolution: {integrity: sha512-8PzkB0arJFV4jJWSGOYR+OEic6aeKMu/osRhBULN6RY0ykby6LKhbmuQ5ublvaas5BOwboah5D87nrHyuh8PPA==}
engines: {node: '>=10.0.0'}
deprecated: Security vulnerability fixed in 5.2.0, please upgrade
basic-ftp@5.2.0:
resolution: {integrity: sha512-8PzkB0arJFV4jJWSGOYR+OEic6aeKMu/osRhBULN6RY0ykby6LKhbmuQ5ublvaas5BOwboah5D87nrHyuh8PPA==}
engines: {node: '>=10.0.0'}

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Danger Check Results

Messages

⚠️

No changeset file found. Please make sure this is intended or add a changeset file.

Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against e309f45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants