Skip to content

Fix/no issue develop fix#880

Closed
fAnselmi-Ledger wants to merge 15 commits intodevelopfrom
fix/NO-ISSUE-develop-fix
Closed

Fix/no issue develop fix#880
fAnselmi-Ledger wants to merge 15 commits intodevelopfrom
fix/NO-ISSUE-develop-fix

Conversation

@fAnselmi-Ledger
Copy link
Contributor

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copilot AI review requested due to automatic review settings June 5, 2025 15:42
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner June 5, 2025 15:43
@vercel
Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:45pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2025 3:45pm

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Fails
🚫

Please fix the PR title to match the convention, see CONTRIBUTING.md.

Wrong PR title: Fix/no issue develop fix

ℹ️ Regex to match: /^.+ \(([a-z]+\-?){1,}\) \[(DSDK-[0-9]+|NO-ISSUE|ISSUE-[0-9]+)\]: [A-Z].*/

  • Rules:
    • Must start with a word (usually an emoji)
    • Followed by a SPACE
    • Followed by a scope in parentheses and in LOWERCASE
    • Followed by a SPACE
    • Followed by a JIRA issue number or NO-ISSUE or ISSUE- in [brackets] (uppercase)
    • Followed by a colon (":") and a SPACE
    • Followed by a Capitalized message

ℹ️ Example: ✨ (scope) [DSDK-1234]: My feature

Generated by 🚫 dangerJS against 12747db

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces EIP-7702 support, TLV encoding helpers, a new disconnection flag for APDU sends, and related version bumps and documentation updates.

  • Add new EIP-7702 delegation authorization API in ETH signer and sample app
  • Extend ByteArrayBuilder with TLV encoding methods and tests
  • Introduce triggersDisconnection option in SendApduUseCase and bump package versions

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/signer/signer-eth/CHANGELOG.md Record version 1.5.0 and EIP-7702 API addition
packages/signer/signer-btc/package.json Bump version to 1.0.1
packages/signer/signer-btc/CHANGELOG.md Document patch changes for Bitcoin signer
packages/device-management-kit/src/internal/send/use-case/SendApduUseCase.ts Add triggersDisconnection argument to APDU use case
packages/device-management-kit/src/api/device-action/model/UserInteractionRequired.ts Add SignDelegationAuthorization enum value
packages/device-management-kit/src/api/apdu/utils/ByteArrayBuilder.ts Add TLV encoding methods (encodeInTLVFromHexa, encodeInTLVFromBuffer, encodeInTLVFromUInt64)
packages/device-management-kit/src/api/apdu/utils/ByteArrayBuilder.test.ts Add tests for new TLV encoding methods
apps/sample/src/components/SignerEthView/index.tsx Wire up UI for the new delegation authorization action
apps/docs/pages/docs/references/signers/eth.mdx Add documentation for signDelegationAuthorization method
apps/docs/pages/docs/getting-started.mdx Update version table for signer and context modules
.changeset/soft-humans-hang.md New changeset for the disconnection flag feature
Comments suppressed due to low confidence (4)

packages/device-management-kit/src/api/apdu/utils/ByteArrayBuilder.ts:310

  • The JSDoc for encodeInTLVFromBuffer incorrectly describes adding a hexadecimal string, but this method accepts a Uint8Array buffer. Update the description to accurately reflect that it encodes the provided buffer.
  * Add a Tag-Length-Value encoded hexadecimal string to the data field if it has enough remaining space

apps/docs/pages/docs/getting-started.mdx:45

  • The documentation table updates versions for Solana and Context Module but there are no corresponding version bumps in their package.json files. Ensure the actual package versions are aligned or adjust the docs accordingly.
| Device Signer Solana   | [@LedgerHQ/device-signer-kit-solana](https://www.npmjs.com/package/@ledgerhq/device-signer-kit-solana)         | 1.1.1   |

.changeset/violet-llamas-addestest.md:1

  • Several prior changeset files have been removed, and no changesets were added for the Ethereum and Bitcoin version bumps. To maintain accurate change history and proper release workflows, please add dedicated changesets for each package version bump instead of deleting existing ones.
----

packages/device-management-kit/src/internal/send/use-case/SendApduUseCase.ts:54

  • The method signature now includes the triggersDisconnection parameter but the method-level documentation comment above does not describe this new option. Consider updating the function JSDoc to include a description for triggersDisconnection.
    triggersDisconnection,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants