🐛 (dmk) [NO-ISSUE]: Improve SecureChannel errors management and typing#883
Merged
paoun-ledger merged 1 commit intodevelopfrom Jun 9, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
* Error are now properly typed * Bulk APDUs device status is now verified * Device actions now expose SecureChannel device errors types
paoun-ledger
force-pushed
the
feat/no-issue-secure-channel-device-errors
branch
from
4646458 to
b164403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Bug https://ledgerhq.atlassian.net/browse/LIVE-19430
The main issue is that device response status was not verified at all in bulk APDUs sent through secure channels.
It means some errors such as OutOfMemory are not returned properly.
A small refactor is needed to add some typing to secure channel returned errors, and expose it in device actions.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers