Skip to content

test(mobile): add e2e coverage for wallet 4.0 asset discoverability#18760

Draft
mcayuelas-ledger wants to merge 1 commit into
developfrom
support/live-32761-e2e-asset-discoverability-mobile
Draft

test(mobile): add e2e coverage for wallet 4.0 asset discoverability#18760
mcayuelas-ledger wants to merge 1 commit into
developfrom
support/live-32761-e2e-asset-discoverability-mobile

Conversation

@mcayuelas-ledger

@mcayuelas-ledger mcayuelas-ledger commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests. This PR is the automated coverage: it adds Detox E2E specs for the Wallet 4.0 asset discoverability feature.
  • Impact of the changes:
    • Wallet 4.0 portfolio: stocks empty-discovery section ("Explore all" → market stocks category) and stocks holdings section (title → full stocks list page)
    • Global search: Cryptos/Stocks categories navigate to the correct market category, and typed-ticker result ranking (btc → bitcoin, eth → ethereum)
    • assetDiscoverability is now enabled by default in the shared WALLET_40_FEATURE_FLAGS e2e constant — verify other wallet40 specs are unaffected

📝 Description

Wallet 4.0 introduces the "asset discoverability" experience (stocks discovery/holdings sections on the portfolio and category-aware global search), but it had no end-to-end coverage.

This PR adds Detox E2E specs under e2e/mobile/specs/wallet40/assetDiscoverability.spec.ts, with supporting page objects:

  • New TopBarSearchPage for the global search screen (categories, search input, results).
  • MarketPage helpers to assert the selected market category and to go back.
  • PortfolioPage helpers for the stocks discovery/holdings sections and the full stocks list page.
  • New portfolioWithManyStocks userdata fixture for the holdings scenario.

The shared WALLET_40_FEATURE_FLAGS constant now enables assetDiscoverability by default; the suite also sets it explicitly so it stays self-describing about the flag it relies on. Synchronization is disabled for the suite because the Wallet 4.0 market & global-search screens run continuous animations (Detox never reaches idle on iOS).

Scenarios (TMS): B2CQA-5955 (empty stocks discovery), B2CQA-5956 (stocks holdings), B2CQA-5957 (search categories), B2CQA-5958 (search ranking).

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ledger-wiz-cspm-secret-detection

ledger-wiz-cspm-secret-detection Bot commented Jun 19, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 1 Low
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ✅ Deployed https://web-tools-47wo6ofl3-ledger-hq-prd.vercel.app
Native Storybook Build ⏭️ Skipped
React Storybook Build ⏭️ Skipped

@mcayuelas-ledger mcayuelas-ledger force-pushed the support/live-32761-e2e-asset-discoverability-mobile branch from eae4755 to 1c98aa4 Compare June 19, 2026 08:52
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant