Skip to content

[LWDM] refactor(desktop): remove vault transport support#18782

Draft
OlivierFreyssinet wants to merge 1 commit into
developfrom
support/remove-vault-transport
Draft

[LWDM] refactor(desktop): remove vault transport support#18782
OlivierFreyssinet wants to merge 1 commit into
developfrom
support/remove-vault-transport

Conversation

@OlivierFreyssinet

@OlivierFreyssinet OlivierFreyssinet commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Ledger Wallet Desktop transport registration and normal USB / DMK / Speculos / proxy selection paths
    • Experimental settings and top banner surfaces where Vault Signer used to appear
    • Persisted/e2e userdata that used to carry the obsolete vaultSigner setting

📝 Description

Vault Signer has been decommissioned and no longer needs a legacy LedgerJS transport in Ledger Wallet. This PR removes the @ledgerhq/hw-transport-vault workspace package and disconnects the desktop app from the Vault Signer flow.

The cleanup removes the desktop Vault transport module registration, pseudo-device selection path, settings state/action/selector, modal, banner, experimental settings row, package dependency, lockfile entries, and obsolete English copy. Non-English wording cleanup is intentionally left to the automated localization removal flow.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@live-github-bot live-github-bot Bot added desktop Has changes in LLD mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Jun 19, 2026
@live-github-bot live-github-bot Bot changed the title refactor(desktop): remove vault transport support [LWDM] refactor(desktop): remove vault transport support Jun 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ✅ Deployed https://web-tools-7qua6iudm-ledger-hq-prd.vercel.app
Native Storybook Build ✅ Deployed https://native-ui-storybook-lwq99ft5e-ledger-hq-prd.vercel.app
React Storybook Build ✅ Deployed https://react-ui-storybook-qv8omhia6-ledger-hq-prd.vercel.app

@github-actions

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 7 projects in monorepo, 7 projects with changes.

📊 Quick Summary
Project Total Size Change
desktop-main 2.6 MB -
desktop-preloader 7.1 KB -
desktop-renderer 81.2 MB -
desktop-webviewDappPreloader 0 B -
desktop-webviewPreloader 0 B -
desktop-workers 36.8 KB -
mobile 257.0 MB -
📋 Detailed Reports (Click to expand)

📁 desktop-main

Path: rsdoctor/desktop-main/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.6 MB - -
📄 JavaScript 2.4 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 135.3 KB - -

📁 desktop-preloader

Path: rsdoctor/desktop-preloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 7.1 KB - -
📄 JavaScript 5.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 1.8 KB - -

📁 desktop-renderer

Path: rsdoctor/desktop-renderer/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 81.2 MB - -
📄 JavaScript 28.9 MB - -
🎨 CSS 172.5 KB - -
🌐 HTML 1.8 KB - -
📁 Other Assets 52.2 MB - -

📁 desktop-webviewDappPreloader

Path: rsdoctor/desktop-webviewDappPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 0 B - -
📄 JavaScript 0 B - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-webviewPreloader

Path: rsdoctor/desktop-webviewPreloader/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 0 B - -
📄 JavaScript 0 B - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 desktop-workers

Path: rsdoctor/desktop-workers/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 36.8 KB - -
📄 JavaScript 36.8 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 mobile

Path: rsdoctor/mobile/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 257.0 MB - -
📄 JavaScript 107.9 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 149.1 MB - -

Generated by Rsdoctor GitHub Action

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant