Skip to content

Navigation scenario with spinner#267

Merged
fbeutin-ledger merged 1 commit intomasterfrom
fbe/navigate_with_spinner
Mar 3, 2026
Merged

Navigation scenario with spinner#267
fbeutin-ledger merged 1 commit intomasterfrom
fbe/navigate_with_spinner

Conversation

@fbeutin-ledger
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support to NavigateWithScenario for transaction-review flows that end with a post-validation spinner instead of a status modal, and records the change in the changelog.

Changes:

  • Introduce an optional post_validation_spinner in NavigationScenarioData to adapt validation steps for spinner-ending flows.
  • Update navigation to optionally skip final screen-change assertion and explicitly wait for spinner text.
  • Add a review_approve_with_spinner(...) helper scenario and bump changelog.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/ragger/navigator/navigation_scenario.py Adds spinner-aware navigation scenario support and a new helper method for TX review approval with a spinner.
CHANGELOG.md Documents the new spinner scenario navigation feature under version 1.43.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/navigate_with_spinner branch 2 times, most recently from 55f826e to 2bbd77a Compare March 2, 2026 16:03
agrojean-ledger
agrojean-ledger previously approved these changes Mar 2, 2026
Copy link
Contributor

@agrojean-ledger agrojean-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🚀

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.32%. Comparing base (c7a5b3b) to head (2026992).

Files with missing lines Patch % Lines
src/ragger/navigator/navigation_scenario.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   77.81%   78.32%   +0.50%     
==========================================
  Files          36       36              
  Lines        2182     2191       +9     
==========================================
+ Hits         1698     1716      +18     
+ Misses        484      475       -9     
Flag Coverage Δ
apex_p-py3.10 78.22% <76.92%> (+0.50%) ⬆️
apex_p-py3.11 78.22% <76.92%> (+0.50%) ⬆️
apex_p-py3.12 78.22% <76.92%> (+0.50%) ⬆️
apex_p-py3.13 78.22% <76.92%> (+0.50%) ⬆️
apex_p-py3.9 78.20% <76.92%> (+0.50%) ⬆️
flex-py3.10 78.22% <76.92%> (+0.50%) ⬆️
flex-py3.11 78.22% <76.92%> (+0.50%) ⬆️
flex-py3.12 78.22% <76.92%> (+0.50%) ⬆️
flex-py3.13 78.22% <76.92%> (+0.50%) ⬆️
flex-py3.9 78.20% <76.92%> (+0.50%) ⬆️
nanos-py3.10 76.58% <76.92%> (+0.50%) ⬆️
nanos-py3.11 76.58% <76.92%> (+0.50%) ⬆️
nanos-py3.12 76.58% <76.92%> (+0.50%) ⬆️
nanos-py3.13 76.58% <76.92%> (+0.50%) ⬆️
nanos-py3.9 76.69% <76.92%> (+0.51%) ⬆️
nanosp-py3.10 76.63% <76.92%> (+0.50%) ⬆️
nanosp-py3.11 76.63% <76.92%> (+0.50%) ⬆️
nanosp-py3.12 76.63% <76.92%> (+0.50%) ⬆️
nanosp-py3.13 76.63% <76.92%> (+0.50%) ⬆️
nanosp-py3.9 76.73% <76.92%> (+0.51%) ⬆️
nanox-py3.10 76.58% <76.92%> (+0.50%) ⬆️
nanox-py3.11 76.58% <76.92%> (+0.50%) ⬆️
nanox-py3.12 76.58% <76.92%> (+0.50%) ⬆️
nanox-py3.13 76.58% <76.92%> (+0.50%) ⬆️
nanox-py3.9 76.69% <76.92%> (+0.51%) ⬆️
stax-py3.10 78.22% <76.92%> (+0.50%) ⬆️
stax-py3.11 78.22% <76.92%> (+0.50%) ⬆️
stax-py3.12 78.22% <76.92%> (+0.50%) ⬆️
stax-py3.13 78.22% <76.92%> (+0.50%) ⬆️
stax-py3.9 78.20% <76.92%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@fbeutin-ledger fbeutin-ledger merged commit 04943af into master Mar 3, 2026
58 checks passed
@fbeutin-ledger fbeutin-ledger deleted the fbe/navigate_with_spinner branch March 3, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants