Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enhanced Vector Class #31

Merged
merged 16 commits into from
Dec 28, 2024
Merged

✨ Enhanced Vector Class #31

merged 16 commits into from
Dec 28, 2024

Conversation

SizzinSeal
Copy link
Member

@SizzinSeal SizzinSeal commented Dec 27, 2024

Overview

  • constexpr Vector2D, Vector3D, Pose
  • const Vector member functions
  • vector member functions take const Vector<T>& as an argument
  • templated * and / overloads, lhs and rhs when possible
  • simplified Vector internals
  • removed vectorTo, since it's functionality is fulfilled by the - operator
  • made members variables public, removed setters and getters
  • removed 2D cross product, it does not exist irl
  • slightly modified comments to improve readability
  • use this-> when referring to member variables to improve readability

Motivation

These changes would make it much easier to write LemLib v0.6. So much so that I see them as a requirement for me to continue writing v0.6

@SizzinSeal SizzinSeal marked this pull request as draft December 28, 2024 02:27
@SizzinSeal SizzinSeal self-assigned this Dec 28, 2024
@SizzinSeal SizzinSeal marked this pull request as ready for review December 28, 2024 06:49
@SizzinSeal SizzinSeal requested review from sufferiing and Aang099 and removed request for sufferiing December 28, 2024 06:49
Copy link
Member

@sufferiing sufferiing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, would like to have Jamie look over this also.

@SizzinSeal SizzinSeal merged commit 54e887f into main Dec 28, 2024
3 checks passed
@SizzinSeal SizzinSeal deleted the feat/const-vector-operators branch December 28, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants