Add option to disable the server or client library

[learn-more]

#672

[bk138]

Looks good code wise, there seem to be some edge cases though:

• cmake .. -DWITH_LIBVNCSERVER=OFF
  • wstest.c:(.text+0x105): undefined reference to `rfbLog'
  • cargstest.c:(.text+0x84): undefined reference to `rfbGetScreen'
  • ...and some more, but only the tests
• cmake .. -DWITH_LIBVNCCLIENT=OFF
  • /usr/bin/ld: CMakeFiles/test_encodingstest.dir/test/encodingstest.c.o: warning: relocation against rfbClientLog' in read-only section .text' (they might link against both client and server...)
  • only this test affected AFAICT

[learn-more]

Looks good code wise, there seem to be some edge cases though:

* cmake .. -DWITH_LIBVNCSERVER=OFF
  
  * wstest.c:(.text+0x105): undefined reference to `rfbLog'
  * cargstest.c:(.text+0x84): undefined reference to `rfbGetScreen'
  * ...and some more, but only the tests

* cmake .. -DWITH_LIBVNCCLIENT=OFF
  
  * /usr/bin/ld: CMakeFiles/test_encodingstest.dir/test/encodingstest.c.o: warning: relocation against `rfbClientLog' in read-only section `.text' (they might link against both client and server...)
  * only this test affected AFAICT

Thanks, I will fix those.

Do you also want me to have a go at integrating this in the CI in this PR?

[bk138]

Do you also want me to have a go at integrating this in the CI in this PR?

yes, that's probably a good idea :-)

[learn-more]

Do you also want me to have a go at integrating this in the CI in this PR?

yes, that's probably a good idea :-)

I hope you don't mind, I applied the include feature of the matrix a bit creatively to have readable job names.

[bk138]

almost there! the last install statement with the .pc files needs adapting, too!

[bk138]

Aaand: the set(INSTALL_HEADER_FILES) too.

basically: rfb.h only for server, rfbclient.h only for client.

[learn-more]

almost there! the last install statement with the .pc files needs adapting, too!

Aaand: the set(INSTALL_HEADER_FILES) too.

basically: rfb.h only for server, rfbclient.h only for client.

Both of these should be addressed now.

Thanks for your patience!

---

The includetest does not seem to like the optional header deployment.
I'll add 2 targets, one for the client and one for the server if that's okay with you?