Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove underscore dependency #128

Merged

Conversation

Gaurav0
Copy link
Member

@Gaurav0 Gaurav0 commented Jan 27, 2025

No description provided.

@Gaurav0 Gaurav0 added the refactor changes internal implementation label Jan 27, 2025
@Gaurav0 Gaurav0 self-assigned this Jan 27, 2025
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for liberatedpixelcup ready!

Name Link
🔨 Latest commit 0c70b05
🔍 Latest deploy log https://app.netlify.com/sites/liberatedpixelcup/deploys/6797bd6a2ebc0d0008df13f4
😎 Deploy Preview https://deploy-preview-128--liberatedpixelcup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jrconway3
Copy link
Contributor

I'm not exactly sure what I'm supposed to be looking for here...?

I can run a quick test but otherwise I don't know what this is affecting to know what I should be testing.

@Gaurav0
Copy link
Member Author

Gaurav0 commented Jan 27, 2025

Test that:

  • Search as you type still works (used _.debounce)
  • interpretParams still works
  • setParams still works

Copy link
Contributor

@jrconway3 jrconway3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell everything is working correctly.

I have, however, seen errors related to Bugsnag:

cdp/?deployID=6797bd6a2ebc0d0008df13f4&siteID=5ae804db-e50a-42e2-997e-6ddeba7ab1de&vcs=github:1 
GET https://cdn.segment.com/analytics.js/v1/PzoD1qlC1wpvDGhNckresPQM3zcX8I1s/analytics.min.js net::ERR_BLOCKED_BY_CLIENT
_app.tsx:18 

POST https://sessions.bugsnag.com/ net::ERR_BLOCKED_BY_CLIENT
bootstrap:21 

POST https://sessions.bugsnag.com/ net::ERR_BLOCKED_BY_CLIENT
bootstrap:21 

POST https://sessions.bugsnag.com/ net::ERR_BLOCKED_BY_CLIENT

But it doesn't appear to be affecting the functionality.

@Gaurav0
Copy link
Member Author

Gaurav0 commented Jan 27, 2025

@jrconway3 ^^ I think those are related to the netlify injected code.

@Gaurav0 Gaurav0 merged commit 507b1d2 into LiberatedPixelCup:master Jan 27, 2025
5 checks passed
@Gaurav0 Gaurav0 deleted the gaurav/refactor/remove_underscore branch January 27, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor changes internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants