Update vjp implementation to attach residuals to all outputs #1755
+38
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the interpreting environment
IvanYashchuk
commented
Feb 7, 2025
| @@ -1934,6 +1934,18 @@ def func(x): | |||
| torch.testing.assert_close(actual_gr, expected_gr) | |||
|
|
|||
|
|
|||
| # See https://github.com/Lightning-AI/lightning-thunder/issues/1732 | |||
| def test_symbolic_shape_for_backward_issue_1732(): | |||
There was a problem hiding this comment.
@jjsjann123, is there any other test you tried that didn't work?
|
This is ready for review, the draft status is only to prevent merges into the previous PR. |
IvanYashchuk
force-pushed
the
ivan-1732-1
branch
from
698dfc7 to
3c4b0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PR: #1754, I'm keeping this PR in Draft for stacking PRs
The current code assumes that the first output of all BoundSymbols will be a Proxy with a
.nameattribute. It's not always the case when DCE might replace unused outputs withNoneor some other objects are returned from Symbols.The important changes are:
I added the test from the issue description of #1732.
Fixes #1732.