[Week1] 멋사 레스토랑 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0422
reviewed
Sep 17, 2023
sanghyun/week1.js
Outdated
Comment on lines
11
to
17
| const Status={ | ||
| WAITING: 0, | ||
| COOKING: 1, | ||
| COOKED: 2, | ||
| SERVING: 3, | ||
| SERVED: 4, | ||
| } |
There was a problem hiding this comment.
혹시 Status가 변경될 수 있는 위험을 줄이기 위해 얼리기를 추천드립니다!
const STATUS=Object.freeze({
WAITING: 0,
COOKING: 1,
COOKED: 2,
SERVING: 3,
SERVED: 4,
});
sanghyun/week1.js
Outdated
Comment on lines
67
to
71
| this.chefQueue = []; | ||
| this.serverQueue = []; | ||
| this.finishedQueue = []; | ||
| this.isCooking = false; | ||
| this.isServing = false; |
There was a problem hiding this comment.
지금도 너무 좋지만, 조금 개선할 여지가 있는부분을 말씀드리자면
레스토랑이 셰프 큐와 서버큐, 완료 큐, 그리고 요리 상태와 서빙 상태를 갖고 있네요. 레스토랑이 모든 정보를 다 갖게 되는데 이로인해서 이후에 유지보수, 기능추가에 문제가 생길 수도 있을 것 같습니다.
예를들어서 셰프가 한명 더 생긴다던지, 서버가 한명 더생기는 경우이죠.
이런경우를 고려해서 역할을 조금 더 분리 해보는 건 어떨까요?
There was a problem hiding this comment.
코멘트대로 추가 구현했습니다! 확인 부탁드려요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node Conference - Week1 HW
설계:
EventEmitter를 호출해 각 큐를 진행 시킵니다.EventEmitter()인스턴스가 호출한 이벤트만 listen할 수 있어, 공통 인스턴스를 선언한 후 export 했습니다.chooseChef()와chooseServer()에 로드 밸런싱을 위임했고, 각 1명의 요리사/홀알바를 데리고 있는 것으로 가정해 구현했습니다.emitter선언부를 수정한 커밋이 PR에 안뜨네요..const선언으로 수정했습니다..!결과:
[개선]
