-
Notifications
You must be signed in to change notification settings - Fork 0
8회차 과제 - 김정운 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vni911
wants to merge
6
commits into
main
Choose a base branch
from
feature/kim_jeong_un
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
8회차 과제 - 김정운 #2
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ const FetchMovies = () => { | |
|
|
||
| const sortById = (list) => list.sort((a, b) => a.id - b.id); | ||
|
|
||
| const addWatched = (movie) => { | ||
| const addWatchedList = (movie) => { | ||
| setWatched((prev) => sortById([...prev, movie])); | ||
| setMovies((prev) => sortById(prev.filter((m) => m.id !== movie.id))); | ||
| }; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 영화를 오름차순으로 정렬하고, 제거 후 원래 리스트에 추가되도록 코드를 깔끔히 잘 작성하셨네요! |
||
|
|
@@ -103,7 +103,7 @@ const FetchMovies = () => { | |
| <div>{movie.description}</div> | ||
| <div className="just"> | ||
| <button | ||
| onClick={() => addWatched(movie)} | ||
| onClick={() => addWatchedList(movie)} | ||
| className="bg-white hover:bg-gray-500 text-gray-800 font-semibold py-2 px-4 border border-gray-400 rounded mt-4 mr-3"> | ||
| 시청한 영화 담기 | ||
| </button> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sortById라는 함수를 통해 인덱스를 삭제하면 해당 함수 호출을 통한 정렬을 편리하게 구현하셨군요!