-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Test Report for wasm test cases #103
Conversation
Off the bat the PR should be named something more clear, and it probably shouldnt have your name in it. (The branch name should be better as well but thats fine for now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is very detailed and includes the necessary comments, which is great! The structure is clear, and the logic is well-organized.
I have a few questions and some requests for changes.
@m-hemmings and @yashaswi2000 can you review this today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Replace all names with "gcc" with "native"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f931cc8
to
4d2c133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
PR for the python script that generates the test report.
We take all the files with .c extension. Test cases are considered deterministic or non deterministic by checking the parent folder name.
For determinstic tests, we compile and run using gcc, stores the output and then compiles using wasm and stores the output after running. The outputs are compared and is success if they match.
For non deterministic tests, we compile and using wasm only
All wasm compilations and runs are done using the lindtool.sh bash script
Finally a JSON file is generated with determinstic and non-deterministic as childs and each having the counts/lists of success/failure/timeout/segfaults and a list of all files and what their result was.