Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Test Report for wasm test cases #103

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

ansalma6
Copy link
Contributor

@ansalma6 ansalma6 commented Feb 7, 2025

PR for the python script that generates the test report.
We take all the files with .c extension. Test cases are considered deterministic or non deterministic by checking the parent folder name.
For determinstic tests, we compile and run using gcc, stores the output and then compiles using wasm and stores the output after running. The outputs are compared and is success if they match.
For non deterministic tests, we compile and using wasm only

All wasm compilations and runs are done using the lindtool.sh bash script

Finally a JSON file is generated with determinstic and non-deterministic as childs and each having the counts/lists of success/failure/timeout/segfaults and a list of all files and what their result was.

@rennergade
Copy link
Contributor

Off the bat the PR should be named something more clear, and it probably shouldnt have your name in it. (The branch name should be better as well but thats fine for now).

@ansalma6 ansalma6 changed the title Ansal test report script Generate Test Report for wasm test cases Feb 7, 2025
Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is very detailed and includes the necessary comments, which is great! The structure is clear, and the logic is well-organized.

I have a few questions and some requests for changes.

@rennergade
Copy link
Contributor

@m-hemmings and @yashaswi2000 can you review this today?

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Replace all names with "gcc" with "native"

yashaswi2000
yashaswi2000 previously approved these changes Feb 14, 2025
Copy link
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@rennergade rennergade merged commit 470660a into main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants