Open
Conversation
Owner
|
Thanks, this is awesome work! I will get this merged, but it may take a bit as I'm still focussing on getting v3 for Vue 3 up and running. This will definetely get added when I can make the time though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. We are using your library in our design system. And
portal-vueappears in bundle even when we are not importing dependent components. I checked youresmbundle withagadoo. Seems like your package has problems with tree-shaking.So I added
#__PURE__annotations for everyVue.extend()expression. I think it helped. At leastagadoothinks so.Also I added
size-limitpackage to test tree-shaking and import cost.Before:
After:
There are 2 new commands in
package.json:agadoosize-limitand check bundle sizeI will be glad if you merge this PR or fix it by yourself.