Fix using uppercase in element name#358
Open
hacknug wants to merge 1 commit intoLinusBorg:developfrom
Open
Conversation
Owner
|
I'd be interested to to learn where a linter might protest about this? I used uppercase as tagNames are in fact uppercase in JS DOM: const div1 = document.createElement('DIV')
const div2 = document.createElement('div')
div1.tagName // => 'DIV'
div2.tagName // => 'DIV'Given that Vue uses |
Author
|
Of course! I'm using Attaching a screenshot to show the logged error and generated HTML: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR makes the default name for the portal element lowercase. Some linters don't like it when you use uppercase characters for this and, given browsers turn element and attribute names to lowercase when rendering the page, it's somewhat hard to know where the issue/warning comes from.
More info:
Let me know if you'd like me to make any changes to this PR before mergin it in 👍