forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 0
[ImgBot] Optimize images #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imgbot
wants to merge
1,923
commits into
master
Choose a base branch
from
imgbot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the alias for profiling and output change to keep the classNames and functionNames for human readbility * defined isEnvProductionProfile with other isEnv checks * moved the keep_classnames and keep_fnames to terserOptions scope * resolve merge conflict for yarn.lock.cache * revert yarn.lock.cache to master yarn.lock.cache - git checkout origin/master -- packages/create-react-app/yarn.lock.cached * Comment and Boolean Check - I clarified the comment and specified the use case - Changed the environment check to check for the specific true rather than the assumed primitive value as before. * Replaced env with flag - Per suggestion --profile flag used instead of env variable PROFILE_APP * documentation in available scripts section with suggested information * resolved a local git issue. Fixed documentation error. * moved documentation to suggested file - Added a brief summary of profiling in available scripts section. The summary references the production-build document. Which is the file I moved the new documentation into under a new Header for production support. * Update production-build.md Co-authored-by: Ian Sutherland <[email protected]>
* Update Jest to 26 * Upgrade to Jest 26.0.1 * Use jest-circus test runner by default * Try resolving test runner to fix behavior tests * Run TypeScript verification in new context * Delete globalThis if polyfilled
* Support scss absolute path resolution for url() Adding resolve-url-loader broke all apps using scss with centralized assets folder and all url(./assets/*.png) broke (facebook#7023). This change allows apps to use url(/assets/*.png) and it would map to src/assets/*.png * test: Add global scss assets test
Co-authored-by: Brody McKee <[email protected]> Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Minh Nguyen <[email protected]>
The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning.
* Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn
Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
*Total -- 221.09kb -> 182.75kb (17.34%) /docusaurus/website/static/img/logo-og.png -- 22.54kb -> 9.19kb (59.22%) /packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/assets/tiniest-cat.jpg -- 0.67kb -> 0.28kb (58.9%) /docusaurus/website/static/img/update.png -- 60.70kb -> 36.36kb (40.1%) /packages/cra-template-typescript/template/src/logo.svg -- 2.61kb -> 2.57kb (1.46%) /packages/cra-template/template/src/logo.svg -- 2.61kb -> 2.57kb (1.46%) /packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/assets/logo.svg -- 2.61kb -> 2.57kb (1.46%) /test/fixtures/global-scss-asset-resolution/src/images/logo.svg -- 2.61kb -> 2.57kb (1.46%) /test/fixtures/relative-paths/src/logo.svg -- 2.59kb -> 2.57kb (0.94%) /screencast.svg -- 48.04kb -> 48.01kb (0.07%) /docusaurus/website/static/img/docusaurus.svg -- 76.10kb -> 76.06kb (0.05%) Signed-off-by: ImgBotApp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 17% 🎉
Details
Black Lives Matter | 💰 donate | 🎓 learn | ✍🏾 sign
📝 docs |
repo | 🙋🏾 issues | 🏅 swag | 🏪 marketplace