Update livesplit-core and rust edition

[Eein]

Changes

• changes required set_custom_variable and set_current_comparison params to Cow<'_, str>
• updates livesplit-core
• sets newer rust version and edition in Cargo.toml
• runs cargo fix --edition

I did not run cargo fmt here because it changes files wildly - if that's okay i'll go ahead and run that too and commit

[AlexKnauth]

Should you update livesplit-core again to incorporate the Layout parser changes?

[Eein]

Should you update livesplit-core again to incorporate the Layout parser changes?

Done

Note: I have not tested the layout parser changes and i wont be running for a bit.

Help would be appreciated in making sure things work.

[Eein]

probably bitrotting at this point

[CryZe]

It doesn't find the OBS shared library on Linux. I don't see what changed there or honestly how it ever even found it to begin with?!

Did the GitHub Runner images just have it installed previously?

[Eein]

It doesn't find the OBS shared library on Linux. I don't see what changed there or honestly how it ever even found it to begin with?!

Did the GitHub Runner images just have it installed previously?

Great question!

I'll set up the runners on my fork and see if i can diagnose this when i find some time.

It looks like macos had to do this previously.

https://github.com/LiveSplit/obs-livesplit-one/blob/master/.github/workflows/rust.yml#L134C2-L136C37

It may have included the libraries by default for some reason in an old ubuntu-latest image, and removed to prevent security issues? (maybe when the great XZ Utils purge happened) so just installing the obs libs later might fix this.

[CryZe]

We can also just build the fake shared library we have in this repository, which apparently is also just mostly dead code atm?!

[Eein]

We can also just build the fake shared library we have in this repository, which apparently is also just mostly dead code atm?!

Happy to take a look and give it a shot in the coming weeks - i'd be curious if this works for macos as well.

[Eein]

Figured I'd drop a ping here as well; seems good to me now!

Only did linux for now, but i can test the osx stuff down the road unless someone else gets to it