Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛤️: perform secrets retrieval req via server as proxy #1289

Closed
wants to merge 1 commit into from

Conversation

merryman
Copy link
Member

Fixes an issue where a secrets retrieval request would get rejected by github due to CORS issues.

@merryman merryman requested a review from linusha February 29, 2024 11:51
@linusha
Copy link
Contributor

linusha commented Feb 29, 2024

In principle I have nothing against this change. However, I am wondering how this came up? I was under the assumption that for the api subdomains this is not a problem. If this can become a problem, my next question would be why only for the secret retrieval?

@merryman
Copy link
Member Author

In principle I have nothing against this change. However, I am wondering how this came up? I was under the assumption that for the api subdomains this is not a problem. If this can become a problem, my next question would be why only for the secret retrieval?

It came up when I tried to open up your personal branch on the lively.next website repo. But I openend other branches created by you in that past for different repos. So I can't really parse whats going on here. Are you sure this code path was executed at all times in the past?

@merryman merryman marked this pull request as draft February 29, 2024 18:16
@linusha
Copy link
Contributor

linusha commented Mar 1, 2024

The reason seems to be that GitHub was not running smoothly.

@linusha linusha closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants