Fix/text performance #1683
Merged
Fix/text performance #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusha
force-pushed
the
fix/text-performance
branch
from
369ddf3 to
eef5112
Compare
Co-authored-by: linusha <[email protected]>
linusha
force-pushed
the
fix/text-performance
branch
from
eef5112 to
5699b9b
Compare
linusha
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
After testing this, I believe we can do even better and remove the other attribute as well.
Please take a look and merge at your leisure. I tested this, but I am not 100% sure I thought of all consequences this has, as this logic of the textmorph is quite complex.
In any case, leaving the code that applies the now useless styleclass and the empty CSS class was sloppy, that can go for sure I'd believe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.