Fix/policy application issues #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
fix/policy-application-issues
branch
from
9babbf5 to
9d78442
Compare
Conflicting properties such as width, height, extent or textString, value and textAndAttributes are prioritized and weeded out during synthesization in order to avoid confusing behavior.
Previously the check would give incorrect results when nested breakpoints where being applied. A nested breakpoint is a breakpoint defined by a master that was *itself* reached by a breakpoint.
…flag Replaces old and not very well working control flows with a more sophisticated approach to determining sizing behavior of a styled morph within the context of various layouts. According to the identified sizing behavior, the extent is applied in varying fashions. Also previously accidental re-execution of layouts would happen due to policies applying themselves, which lead to inefficient layout applications overall. This is now prevented with a meta flag.
Previously some layout applications, including text layout, would cause extent, height or width properies in style policies to no longer apply, although not warranted.
merryman
force-pushed
the
fix/policy-application-issues
branch
from
9d78442 to
d42c366
Compare
linusha
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues with style policies such as: