-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
更新了cn的基础镜像,用于解决maa的GLIBC_2.34缺失问题 #4637
Open
Lyiyeyulongwu
wants to merge
2
commits into
LmeSzinc:master
Choose a base branch
from
Lyiyeyulongwu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要动基础镜像了,所有环境就固定在当前时间节点或者当年的时间节点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmeszinc 我很理解你需要固定环境的想法,但是,这是docker当初的设计的问题,注意,我所更改的文件是Dockerfile.cn 而不是Dockerfile 这是因为在Dockerfile中他所使用的镜像是python:3.7-slim,这是一个动态镜像,他会实时更新最新版本,在当时建立的时候他使用的文件是python:3.7-slim-bullseye,而在现在这个镜像标签下面使用的是python:3.7-slim-bookworm,至于为什么Dockerfile.cn需要指示到具体的,而不是使用动态镜像标签,这是因为换源的地址需要指示到具体的版本,所以我认为我的提交是必须且应该的,在Dockerfile文件里面指示的镜像,已经是最新的bookworm了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是需要修改的,他的最底层镜像还是debian11了
这是我提交修改的镜像
LmeSzinc,提供镜像的SHA256标签,你也应该明白python:3.7-slim目前确实是指向python:3.7-slim-bookworm的