-
Notifications
You must be signed in to change notification settings - Fork 967
Opt: use LoggerUnlock in storage #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
implementation seems reasonable and functionally does not hinder anything but would wait on owner's input whether really need to add to
|
63b86fa to
76cc240
Compare
thx for suggestions |
that is fair argument though if a user wants to min max opsi then it be weird for them to not have it enabled anyway looks fine for the most part, probably just wait on owner input if any. if no traction, I see no potential negative impact and can merge just had one more comment, not sure if it was intentional given |
|
@LmeSzinc any concerns with this merging? feels like a small add quick step in the daily process if anything, I might suggest given this is for the unlock logger after voucher shop, maybe just place it after this https://github.com/LmeSzinc/AzurLaneAutoScript/blob/master/module/os/operation_siren.py#L308 but I get the idea of wanting to use all the loggers daily too so it can just do so naturally that way, but at the same time I think loggers are only effectively used during |
|
测试用掉记录仪的log |
|
加上另一个记录仪的自动使用,默认有就是使用,不增加设置。游戏里买了还要手动使用的设计挺让人无语的 |
76cc240 to
ec960db
Compare
对于隐秘海域信息记录,点击 BOX_USE 后直接退出到仓库 INFO 2025-10-01 15:51:18.562 │ [Story_options] 1 |
module/os/operation_siren.py
Outdated
| # Clear tuning samples daily | ||
| if self.config.OpsiDaily_UseTuningSample: | ||
| self.tuning_sample_use() | ||
| self.tuning_sample_use(quit=not self.config.OpsiGeneral_UseLogger) | ||
| if self.config.OpsiGeneral_UseLogger: | ||
| self.logger_use() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在没有 OpsiGeneral_UseLogger 了,也不需要分开两次调用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
Fix: match LoggerUnlockT1 and LoggerUnlockT2 Add: use LoggerUnlock after voucher shop Upd: logger_use after voucher shop only
ec960db to
b9c4870
Compare
使用仓库内的战役信息记录仪和隐秘海域信息记录仪,图片用image_fixup处理过了