Implement Display for ByteOffset #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch ErrorTree<BytesOffset> does not implement Error which makes using it (e.g. with final_parser) a lot more cumbersome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for the collection of QoL improvements to nom!
I think you missed implementing Display for BytesOffset (it is implemented for Location).
Without this patch ErrorTree does not implement Error which
makes using it (e.g. with final_parser) a lot more cumbersome.
With it the result can be reported using Try and anyhow/eyre:
Error: in section "value" at byte offset 2,
expected eof at byte offset 2