Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing default props on sdk request, when option prop passed #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SirSerje
Copy link

fix for #46
You can pass both default props, of course, but it's not clear for newcomers to lib
Please, review and give some comments

@SirSerje SirSerje changed the title #46 Missing default props on sdk request, when option prop fix : Missing default props on sdk request, when option prop Dec 23, 2019
Copy link

@romanmtb romanmtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint also broken, update it, if possible:
.eslintignore : src/tests/*
package.json : "lint": "./node_modules/.bin/eslint src/** example/**",

@SirSerje SirSerje changed the title fix : Missing default props on sdk request, when option prop fix: Missing default props on sdk request, when option prop passed Dec 23, 2019
@tridentwizard
Copy link

Hey can this get merge in ?

@SirSerje
Copy link
Author

Hey can this get merge in ?

I think, yes, this PR does not break any other logic of the lib

@SirSerje
Copy link
Author

SirSerje commented Oct 4, 2022

Hey can this get merge in ?

I think to fork this repo is the best option for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants