Skip to content

pre-commit-hook with ruff#256

Merged
jlaehne merged 1 commit intoLumiSpy:mainfrom
Lulus792:pre-commit-hook
Mar 24, 2026
Merged

pre-commit-hook with ruff#256
jlaehne merged 1 commit intoLumiSpy:mainfrom
Lulus792:pre-commit-hook

Conversation

@Lulus792
Copy link
Copy Markdown
Contributor

@Lulus792 Lulus792 commented Mar 16, 2026

Implemented pre-commit-hook with ruff. If installed it runs a lint and format check on the files.

Progress of the PR

  • Change implemented (can be split into several points),
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • ready for review.

Minimal example of the bug fix or the new feature

pre-commit install
pre-commit run --all-files

Note: not sure how to name the changelog entry

Copy link
Copy Markdown
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good apart from one question relating to imports

Comment thread lumispy/signals/luminescence_transientspec.py
Comment thread upcoming_changes/256.enhancements.rst Outdated
@jlaehne
Copy link
Copy Markdown
Contributor

jlaehne commented Mar 19, 2026

We mention the code style in the contributor guide, so please change adapt that section:
https://docs.lumispy.org/en/stable/contributing.html#code-style

And add an intersphinx link to the section in the hyperspy dev guide:
https://hyperspy.org/hyperspy-doc/current/dev_guide/coding_style.html#coding-style

@jlaehne
Copy link
Copy Markdown
Contributor

jlaehne commented Mar 24, 2026

Failing test is fixed in #257

@jlaehne jlaehne merged commit 9d5ca9a into LumiSpy:main Mar 24, 2026
9 of 18 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (bcd4d5d) to head (a851759).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #256   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants