Merged
Conversation
2d0bbba to
9bf4642
Compare
jlaehne
approved these changes
Mar 17, 2026
Contributor
jlaehne
left a comment
There was a problem hiding this comment.
Thanks, looks good apart from one question relating to imports
9bf4642 to
f44f90c
Compare
Contributor
|
We mention the code style in the contributor guide, so please change adapt that section: And add an intersphinx link to the section in the hyperspy dev guide: |
updated the documentation
f44f90c to
a851759
Compare
Contributor
|
Failing test is fixed in #257 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented pre-commit-hook with ruff. If installed it runs a lint and format check on the files.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),Minimal example of the bug fix or the new feature
Note: not sure how to name the changelog entry