-
Notifications
You must be signed in to change notification settings - Fork 9
feat: 保持谱面流速不受播放速度影响 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+78
−10
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0d5a819
feat: 保持谱面流速不受播放速度影响
saltcute f37fffb
fix: use consistent naming scheme
saltcute efd3d77
fix: reduce branch complexity
saltcute 3c7e070
feat: 添加保持谱面流速选项及帮助提示
JoinChang ee3f939
Merge remote-tracking branch 'origin/main' into pr/saltcute/12
JoinChang 88f6aa6
feat: 添加保持固定流速选项到游戏设置
JoinChang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -42,6 +42,8 @@ export class MainRenderer { | |||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| private config: RendererConfig = { | ||||||||||||||||||||||||||||
| hiSpeed: HI_SPEED_DEFAULT * HI_SPEED_CONVERSION_FACTOR, | ||||||||||||||||||||||||||||
| alwaysKeepHiSpeed: false, | ||||||||||||||||||||||||||||
| playbackSpeed: 1.0, | ||||||||||||||||||||||||||||
| mirrorMode: 'none', | ||||||||||||||||||||||||||||
| highlightExNotes: false, | ||||||||||||||||||||||||||||
| normalColorBreakSlide: false, | ||||||||||||||||||||||||||||
|
|
@@ -164,6 +166,18 @@ export class MainRenderer { | |||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| setAlwaysKeepHiSpeed(alwaysKeepHighSpeed: boolean): void { | ||||||||||||||||||||||||||||
| this.config.alwaysKeepHiSpeed = alwaysKeepHighSpeed; | ||||||||||||||||||||||||||||
saltcute marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||
| this.updateRenderersContext(); | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| setPlaybackSpeed(playbackSpeed: number): void { | ||||||||||||||||||||||||||||
| if (playbackSpeed >= 0.1 && playbackSpeed <= 1.0) { | ||||||||||||||||||||||||||||
| this.config.playbackSpeed = playbackSpeed; | ||||||||||||||||||||||||||||
| this.updateRenderersContext(); | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
Comment on lines
+175
to
+178
|
||||||||||||||||||||||||||||
| if (playbackSpeed >= 0.1 && playbackSpeed <= 1.0) { | |
| this.config.playbackSpeed = playbackSpeed; | |
| this.updateRenderersContext(); | |
| } | |
| if (playbackSpeed < 0.1 || playbackSpeed > 1.0) { | |
| console.warn( | |
| `MainRenderer.setPlaybackSpeed: playbackSpeed ${playbackSpeed} is out of range [0.1, 1.0]; ignoring value.`, | |
| ); | |
| return; | |
| } | |
| this.config.playbackSpeed = playbackSpeed; | |
| this.updateRenderersContext(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getApproachTimeMsuses a nested division (baseApproachTimeMs / (hiSpeed / playbackSpeed)). This is mathematically equivalent to(baseApproachTimeMs * playbackSpeed) / hiSpeedand can be rewritten to reduce operations and make the intent (scale approach window by playback speed) clearer.