Fix misdetection of text direction due to neutral characters #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a line started with a neutral character (such as a space or quotation mark), the text direction was incorrectly detected as left-to-right (LTR), regardless of whether the text was actually right-to-left (RTL). This led to incorrect rendering of messages, particularly for languages that use RTL text direction.
Text direction was incorrectly detected as LTR when line started with neutral characters, resulting in improper rendering of RTL text:
Text direction is now correctly detected based on the actual text content, leading to proper rendering of RTL text even when preceded by neutral characters: