Skip to content

fix(anthropic): 增强聊天适配器的输出逻辑，添加推理结果处理 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me2seeks merged 1 commit into from
Jun 25, 2025
Merged

fix(anthropic): 增强聊天适配器的输出逻辑，添加推理结果处理 #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkg/llminterface/anthropic/anthropic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@ func (a *AnthropicAdapter) Chat(ctx context.Context, input llminterface.ChatInpu
},
}
outputChan <- chunk

case anthropic.ThinkingDelta:
chunk := llminterface.ChatOutputChunk{
Reasoning: Some(deltaVariant.JSON.Thinking.Raw()),
}
outputChan <- chunk
case anthropic.InputJSONDelta:
// 工具调用参数增量
currentToolArgs.WriteString(deltaVariant.PartialJSON)
Expand Down Expand Up @@ -190,7 +194,11 @@ func (a *AnthropicAdapter) Chat(ctx context.Context, input llminterface.ChatInpu
chunk := llminterface.ChatOutputChunk{
Error: stream.Err(),
}
outputChan <- chunk

// 只有当有实际内容时才发送 chunk
if len(chunk.ContentParts) > 0 || chunk.Reasoning.IsSome() {
outputChan <- chunk
}
Comment on lines +198 to +201
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The conditional check if len(chunk.ContentParts) > 0 || chunk.Reasoning.IsSome() prevents stream errors from being propagated. Since chunk.ContentParts is empty and chunk.Reasoning is None when an error occurs, the error chunk is never sent, silently ignoring the error. Revert to unconditionally sending the error chunk to ensure proper error propagation.

Suggested change
// 只有当有实际内容时才发送 chunk
if len(chunk.ContentParts) > 0 || chunk.Reasoning.IsSome() {
outputChan <- chunk
}
outputChan <- chunk

}
}()

Expand Down