Skip to content

Commit

Permalink
Fixes deprecation warning and updated CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
tanishy7777 committed Dec 12, 2024
1 parent a27591c commit 407bd9e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion package/CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ The rules for this file:


-------------------------------------------------------------------------------
??/??/?? IAlibay, ChiahsinChu, RMeli
??/??/?? IAlibay, ChiahsinChu, RMeli, tanishy7777

* 2.9.0

Fixes
* Fixes deprecation warning Array to scalar convertion. Replaced atan2() with np.arctan2()

Enhancements
* Add check and warning for empty (all zero) coordinates in RDKit converter (PR #4824)
Expand Down
2 changes: 1 addition & 1 deletion package/MDAnalysis/analysis/nuclinfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def phase_cp(universe, seg, i):
+ (r3_d * cos(4 * pi * 2.0 / 5.0)) + (r4_d * cos(4 * pi * 3.0 / 5.0))
+ (r5_d * cos(4 * pi * 4.0 / 5.0))) * sqrt(2.0 / 5.0)

phase_ang = (atan2(D, C) + (pi / 2.)) * 180. / pi
phase_ang = (np.arctan2(D, C) + (pi / 2.)) * 180. / pi
return phase_ang % 360


Expand Down

0 comments on commit 407bd9e

Please sign in to comment.