-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on smaller pdb for guesser to reduce test duration #4893
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4893 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21795 22861 +1066
Branches 3067 3067
===========================================
+ Hits 20413 21406 +993
- Misses 931 1004 +73
Partials 451 451 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black
is unhappy, but otherwise LGTM
@orbeckst This one should be a quick review and merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a core dev approval and it looks good to me as well.
The only CI failure is unrelated, so in it goes, thanks.
Thanks! |
Thanks @yuxuanzhuang and @tylerjereddy ! |
Fixes #4842
Changes made in this Pull Request:
PDB_small
for guesser tests.Reduce from
============================= slowest 50 durations =============================
93.06s call MDAnalysisTests/guesser/test_base.py::TestBaseGuesser::test_guessing_angles_respects_bond_kwargs
40.04s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-20-50-2-15]
39.70s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-20-50-None-30]
39.64s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-None-50-2-25]
38.50s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-None-None-2-49]
30.85s call MDAnalysisTests/analysis/test_rms.py::TestRMSD::test_rmsd_atomgroup_selections[client_RMSD1]
30.65s call MDAnalysisTests/analysis/test_rms.py::TestRMSD::test_weights_mass_is_mass_weighted[client_RMSD1]
28.09s call MDAnalysisTests/guesser/test_base.py::TestBaseGuesser::test_guess_topology_objects_out_of_order_guess
26.96s call MDAnalysisTests/analysis/test_contacts.py::TestContacts::test_contacts_selections[client_Contacts1]
26.27s call MDAnalysisTests/guesser/test_base.py::TestBaseGuesser::test_guess_topology_objects_out_of_order_init
23.74s setup MDAnalysisTests/analysis/test_bat.py::TestBAT::test_bat_IO[client_BAT1]
to
============================= slowest 50 durations =============================
39.72s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-20-50-2-15]
39.54s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-20-50-None-30]
39.50s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-None-50-2-25]
39.38s call MDAnalysisTests/analysis/test_base.py::test_AnalysisFromFunction[client_AnalysisFromFunction1-None-None-2-49]
29.26s call MDAnalysisTests/analysis/test_rms.py::TestRMSD::test_rmsd_atomgroup_selections[client_RMSD1]
29.25s call MDAnalysisTests/analysis/test_rms.py::TestRMSD::test_weights_mass_is_mass_weighted[client_RMSD1]
26.90s call MDAnalysisTests/analysis/test_contacts.py::TestContacts::test_contacts_selections[client_Contacts1]
23.60s setup MDAnalysisTests/analysis/test_bat.py::TestBAT::test_bat_IO[client_BAT1]
19.68s call MDAnalysisTests/guesser/test_default_guesser.py::test_aromaticity
17.90s call MDAnalysisTests/analysis/test_rms.py::TestRMSD::test_ref_mobile_mass_mismapped[client_RMSD1]
17.79s call MDAnalysisTests/coordinates/test_pdb.py::test_conect_bonds_all