Skip to content

Conversation

@Aryaman-Chaudhri
Copy link

@Aryaman-Chaudhri Aryaman-Chaudhri commented Nov 1, 2025

Fixes #5136

Changes made in this Pull Request:

  • Added 5 missing contributors from v2.10.0 to the CHANGELOG file.
  • Added 1 missing contributor from v2.10.0 to the ! AUTHORS file.

PR Checklist

  • Issue raised/referenced?
  • Tests updated/added?
  • Documentation updated/added?
  • package/CHANGELOG file updated?
  • Is your name in package/AUTHORS? (If it is not, add it!)

Developers Certificate of Origin

I certify that this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE is my own original work.

  • I agree to the Developer Certificate of Origin.

📚 Documentation preview 📚: https://mdanalysis--5139.org.readthedocs.build/en/5139/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

package/AUTHORS Outdated
- Matthew Davies
- Jia-Xin Zhu
- Tanish Yelgoe
Here is the updated list for you to copy and paste into the `! AUTHORS` file. I have added `Pradyumn-cloud` to the end of the 2025 list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a leftover comment from an LLM / AI coding tool?

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.73%. Comparing base (5c7c480) to head (804c27d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5139      +/-   ##
===========================================
+ Coverage    92.68%   92.73%   +0.04%     
===========================================
  Files          180      180              
  Lines        22452    22452              
  Branches      3186     3186              
===========================================
+ Hits         20809    20820      +11     
- Misses        1169     1176       +7     
+ Partials       474      456      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove the odd comment in the authors file.
  2. Did you check that there were no other authors missing? The list in the original issue was not an exhaustive list but rather just "those that I came across".

@Aryaman-Chaudhri
Copy link
Author

Hi Irfan, thanks for the review! I've removed the stray comment and pushed the fix.

I also went through all the PRs listed in the 2.10.0 changelog and checked their authors against the contributor list. It looks like the 5 authors from the issue were the only ones missing.

I believe the list is complete now. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several contributions from v2.10.0 are missing from either changelog or authors

2 participants