Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding eddy viscous damping to TDC #735

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

adding eddy viscous damping to TDC #735

wants to merge 16 commits into from

Conversation

pmocz
Copy link
Member

@pmocz pmocz commented Oct 1, 2024

No description provided.

@pmocz pmocz self-assigned this Oct 1, 2024
@Debraheem Debraheem changed the title [Draft]: reviving adding eddy viscous damping to TDC adding eddy viscous damping to TDC Feb 15, 2025
@Debraheem Debraheem marked this pull request as ready for review February 15, 2025 18:13
@Debraheem Debraheem self-assigned this Feb 15, 2025
@Debraheem Debraheem added enhancement New feature or request tdc labels Feb 15, 2025
@Debraheem
Copy link
Member

Debraheem commented Feb 15, 2025

Things left to do:

-move alfam from controls_dev.defaults to controls.defaults?
-add documentation on what Eq and Uq represent, and document other TDC controls.
-add condition that skips calculating Eq and Uq if .not. v_flag = .true.
-minor clean up of commented quantities and spacing.
-run a full test on the test_suite.

@Debraheem
Copy link
Member

MESA-TDC_rehash.pdf
I've attached a re-hash of some of Adam's notes on MESA-TDC versus RSP (neglecting the luminosity equation for this discussion and the differences therein). In this PR, we have added the Eq and Uq terms back into the equations to bring MESA-TDC in closer agreement with MESA-RSP.

@Debraheem Debraheem requested a review from rsmolec as a code owner March 17, 2025 05:45
@Debraheem
Copy link
Member

Debraheem commented Mar 17, 2025

lots of clean up and testing needed on my end, but I would like to make these test cases work before merging this branch.

@Debraheem
Copy link
Member

Some of the RSP test_cases need checked as well, as I have confirmed some of them decay instead of grow in the current branch, hence the initial conditions need tweaked slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tdc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants