add conv_vel cs limit to mlt/tdc #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debraheem
added
documentation
Debraheem
commented
Feb 9, 2025
…rol opacity_min to introduce opacity floor
Adding support to max_conv_vel_div_csound (non-TDC MLT options) and adding opacity_min control
replace max_conv_vel_div_cs with max_conv_vel. still missing csound from star.
fixes.
|
This pr needs a changelog, and some testing, then it will be ready for a merge. |
|
Reconsideration, perhaps we can introduce a convective enthalpy flux limiter as well for TDC, as in Radek's thesis. This might be more appropriate than a strict convective velocity limter for TDC. It might help convergence on the pre-ms for TDC. https://acta.astrouw.edu.pl/Vol58/n3/pap_58_3_4.pdf. This would be useful for RSP as well. |
Debraheem
commented
Mar 8, 2025
| if (s% use_Ledoux_criterion) then | ||
| gradL = grada + gradL_composition_term ! Ledoux temperature gradient | ||
| else | ||
| gradL = grada | ||
| end if | ||
|
|
||
| ! maximum convection velocity. | ||
| if (k>=1) then |
There was a problem hiding this comment.
Unfortunately checking if associated(s% Csound_face) .and. associated(s% q) still yields in backtrace errors from astero in the fast_from_file and other tests, see https://testhub.mesastar.org/EbF%2Fadd_Cs_limit_to_TDC/commits/0a89a8e.
Using a check for k >=1 seems to work better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make use of deprecated controls
max_conv_vel_div_csoundandmax_conv_vel_div_csound_maxqby request #776 and #373. This pr introduces a cs limiter, initially designed by adam/pablo for tdc. We can also introduce a limit for mlt, similar to the one present in previous releases. At the moment, this pr only includes the cs limiter for conv_vel inside TDC.This pr has also highlighted some potential issues in the building of the pre_ms_model. We are unable to call
s% q(k)inside mlt when building the pre_ms_model because it is not yet set. In fact, I've marked a couple statements inside the pms build routine which could be problematic.I don't mind removing
max_conv_vel_div_csound_maxq, but ideally, we can call q(k) inside the mlt_routine during the pms model creation.worst case, we don't introduce either of these controls, but in that case we should remove them all together.