Skip to content

Correct the loop for NoahMP snow initialization check - capping maximum SWE for 2000mm #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Correct the loop for NoahMP snow initialization check - capping maximum SWE for 2000mm #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core_atmosphere/physics/physics_noahmp/drivers/mpas/NoahmpInitMainMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ subroutine NoahmpInitMain(NoahmpIO)

! Check if snow/snowh are consistent and cap SWE at 2000mm
! the Noah-MP code does it internally but if we don't do it here, problems ensue
do i = its, its
do i = its, ite
if ( NoahmpIO%snow(i) < 0.0 ) NoahmpIO%snow(i) = 0.0
if ( NoahmpIO%snowh(i) < 0.0 ) NoahmpIO%snowh(i) = 0.0
if ( (NoahmpIO%snow(i) > 0.0) .and. (NoahmpIO%snowh(i) == 0.0) ) &
Expand Down