#patch (2631) [ACTION] Empêcher la création et la validation de métriques vides#1430
Merged
superfeedboy merged 6 commits intodevelopfrom Mar 25, 2026
Merged
#patch (2631) [ACTION] Empêcher la création et la validation de métriques vides#1430superfeedboy merged 6 commits intodevelopfrom
superfeedboy merged 6 commits intodevelopfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
superfeedboy
reviewed
Mar 6, 2026
Contributor
superfeedboy
left a comment
There was a problem hiding this comment.
Proposition de simplification et correction de nommage de fonction fléchée exportée
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🛠 Description de la PR
Problème
Lorsqu'un utilisateur saisissait des indicateurs pour une année puis supprimait toutes les valeurs,
une ligne vide restait dans la table
action_metrics. Cette ligne vide causait une erreur de validationlors de la modification des dates de début/fin de l'action si l'année ne correspondait plus à la période
d'exécution.
Exemple : action du 01/01/2026 au 26/02/2026, avec une ligne vide pour 2025 → erreur "L'année 2025 n'est pas valide"
Solution
resetAsideData)Changements
hasMetricValues()pour détecter les métriques videsinsertMetrics()pour ne plus insérer les années sans données