Fix: delete BAN address on edit and show 'Non renseigné' when BAN fie…

…ld is empty
MTES-MCT · Feb 24, 2025 · 4ba1dc1 · 4ba1dc1
1 parent ff478d0
commit 4ba1dc1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/frontend/src/components/Campaign/CampaignRecipients.tsx b/frontend/src/components/Campaign/CampaignRecipients.tsx
@@ -96,8 +96,8 @@ function CampaignRecipients(props: Props) {
     <>
       {housing.owner.banAddress
         ? formatAddress(housing.owner.banAddress)
-        : null}
-      {!isBanEligible(housing.owner.banAddress) && (
+        : 'Non renseigné'}
+      {housing.owner.banAddress && !isBanEligible(housing.owner.banAddress) && (
         <Badge severity="info" small>
           Adresse améliorable
         </Badge>

diff --git a/server/src/controllers/ownerController.ts b/server/src/controllers/ownerController.ts
@@ -176,7 +176,7 @@ async function update(
         'updated_at'
       ]
     }),
-    banAddress ? banAddressesRepository.save(banAddress) : Promise.resolve(),
+    banAddress ? banAddressesRepository.save(banAddress) : banAddressesRepository.remove(existingOwner.id, AddressKinds.Owner),
     hasIdentityChanges(existingOwner, owner)
       ? eventRepository.insertOwnerEvent({
           id: uuidv4(),

diff --git a/server/src/repositories/banAddressesRepository.ts b/server/src/repositories/banAddressesRepository.ts
@@ -109,8 +109,25 @@ export const formatAddressApi = (address: AddressApi): AddressDBO => ({
     : undefined
 });
 
+export const remove = async (
+  refId: string,
+  addressKind: AddressKinds
+) => {
+  logger.debug('Get ban adresse with ref id', {
+    ref: refId,
+    addressKind
+  });
+  await db(banAddressesTable)
+    .where('ref_id', refId)
+    .andWhere('address_kind', addressKind)
+    .delete();
+
+    logger.debug(`Deleted ${addressKind} refId=${refId} address.`);
+};
+
 export default {
   save,
   saveMany,
   getByRefId,
+  remove,
 };