Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue dashboard #794

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Add queue dashboard #794

merged 5 commits into from
Jul 10, 2024

Conversation

Falinor
Copy link
Collaborator

@Falinor Falinor commented Jun 24, 2024

The queue dashboard should be available there, with basic auth enabled.

Copy link
Collaborator

@loicguillois loicguillois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça a l'air top !

@Falinor
Copy link
Collaborator Author

Falinor commented Jun 26, 2024

ça a l'air top !

Oui c’est pas mal mais il faudrait ajouter une authentification pour pouvoir déployer ! Une page de basic auth ferait l’affaire

@@ -0,0 +1 @@
[email protected]:$apr1$6ts5byl3$575IQxAARDD6llSdjDpQM0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je préfèrerais que l'on génère le fichier dynamiquement avec une action. On peut stocker le mot de passe dans un secret GitHub et utiliser une action write-file https://github.com/marketplace/actions/write-file par exemple

import auth from 'http-auth';
import path from 'node:path';

export const createBasicAuth = () =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top !

@Falinor Falinor merged commit 4eb4b76 into main Jul 10, 2024
20 of 22 checks passed
@Falinor Falinor deleted the feat-add-queue-dashboard branch July 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants