Better navigation on "Edit" #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sven-n , don't mark the issue as solved yet, I'll look into the breadcrumb later |
|
If everyone's ok with this new tab implementation, can we merge it for now, and do another PR for the breadcrumbs? xD |
|
Okay, I'll take a look as soon as I can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was made for issue #518
The "Edit" are now links, they can be opened in the current tab or in a new tab.
PS. I didn't alter the Merchants "Edit" button since it was not simply an URL, I'll have to look further into it.
I also added a "Drop Item Groups" in the navbar. It'll be easier to use it this way.