Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

CI: Bump Numpy for aarch Python 3.7 #142

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Jul 7, 2021

closes #121
The min version for numpy on aarch should be 1.19.1 I think(otherwise tests fail).
Was not caught in #141 because Travis CI doesn't run on PRs.

@lithomas1 lithomas1 closed this Jul 7, 2021
@lithomas1 lithomas1 reopened this Jul 7, 2021
@lithomas1
Copy link
Contributor Author

lithomas1 commented Jul 7, 2021

Can an admin(someone with write access) on this repo please turn on Travis for PRs again? Currently, it doesn't run with a message saying Build type disabled via repository settings.

@lithomas1
Copy link
Contributor Author

cc @simonjayhawkins

@simonjayhawkins
Copy link
Collaborator

Can an admin(someone with write access) on this repo please turn on Travis for PRs again?

we share this repo with several projects https://github.com/MacPython.

I turned off travis on PRs because of the limit on credits. MacPython/scipy-wheels#106

Not sure what is the status currently is on credits. @mattip?


If the tests fail on release the wheels don't get uploaded and then the pre-built binaries for that are missing from that release.

This was a regular occurrence. Since we don't have the same test env on pandas we are not catching errors there.

I think we (@jreback and myself) have discussed turning testing off for Travis and only build the wheels (similar to pandas-feedstock where the test is just that pandas imports)

@simonjayhawkins
Copy link
Collaborator

The min version for numpy on aarch should be 1.19.1 I think(otherwise tests fail).

not sure. all wheels built (and tested and uploaded) ok for 1.3 (3.7 aarch64 wheels failed for 1.2.5 release)

cc @janaknat

@lithomas1
Copy link
Contributor Author

lithomas1 commented Jul 8, 2021

@simonjayhawkins I think I found the issue.

  Attempting uninstall: numpy
    Found existing installation: numpy 1.16.5
    Uninstalling numpy-1.16.5:
      Successfully uninstalled numpy-1.16.5
Successfully installed numpy-1.21.0 

This was part of the logs for the 1.3 release on 3.7, which indicates that the job was pulling a newer version of numpy that supports aarch.On 1.2.5, I think 1.16.5 was still an accepted version of numpy for pandas, so the tests failed(numpy didn't support aarch back then I think). Since I the other jobs run fine on 1.19.1 we can probably try it.

Regarding the CI on PRs, maybe if there aren't enough credits, we can just turn it on and off quickly just for this one PR. There's no other way to test that this works, unfortunately, without Travis CI on.

@mattip
Copy link

mattip commented Jul 8, 2021

Not sure what is the status currently is on credits. @mattip?

As far as I can tell they stopped billing us, our credits still stand at the same level they were at a few months ago.

@mattip
Copy link

mattip commented Jul 8, 2021

NumPy is using travis for every PR and we seem to be doing OK, sothe occasional builds here should be fine.

@simonjayhawkins
Copy link
Collaborator

closed and reopened to trigger Travis.

@simonjayhawkins
Copy link
Collaborator

NumPy is using travis for every PR and we seem to be doing OK, sothe occasional builds here should be fine.

Thanks @mattip will probably turn off Travis for PRs again after this one.

@lithomas1 lithomas1 closed this Jul 9, 2021
@lithomas1 lithomas1 reopened this Jul 9, 2021
@lithomas1
Copy link
Contributor Author

@simonjayhawkins Green.

@simonjayhawkins simonjayhawkins merged commit f9aba57 into MacPython:master Jul 9, 2021
@simonjayhawkins
Copy link
Collaborator

Thanks @lithomas1

@lithomas1 lithomas1 deleted the patch-1 branch July 9, 2021 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas 1.2.0 python 3.7 aarch64 wheels
3 participants