-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
Can an admin(someone with write access) on this repo please turn on Travis for PRs again? Currently, it doesn't run with a message saying Build type disabled via repository settings. |
we share this repo with several projects https://github.com/MacPython. I turned off travis on PRs because of the limit on credits. MacPython/scipy-wheels#106 Not sure what is the status currently is on credits. @mattip? If the tests fail on release the wheels don't get uploaded and then the pre-built binaries for that are missing from that release. This was a regular occurrence. Since we don't have the same test env on pandas we are not catching errors there. I think we (@jreback and myself) have discussed turning testing off for Travis and only build the wheels (similar to pandas-feedstock where the test is just that pandas imports) |
not sure. all wheels built (and tested and uploaded) ok for 1.3 (3.7 aarch64 wheels failed for 1.2.5 release) cc @janaknat |
@simonjayhawkins I think I found the issue.
This was part of the logs for the 1.3 release on 3.7, which indicates that the job was pulling a newer version of numpy that supports aarch.On 1.2.5, I think 1.16.5 was still an accepted version of numpy for pandas, so the tests failed(numpy didn't support aarch back then I think). Since I the other jobs run fine on 1.19.1 we can probably try it. Regarding the CI on PRs, maybe if there aren't enough credits, we can just turn it on and off quickly just for this one PR. There's no other way to test that this works, unfortunately, without Travis CI on. |
As far as I can tell they stopped billing us, our credits still stand at the same level they were at a few months ago. |
NumPy is using travis for every PR and we seem to be doing OK, sothe occasional builds here should be fine. |
closed and reopened to trigger Travis. |
Thanks @mattip will probably turn off Travis for PRs again after this one. |
@simonjayhawkins Green. |
Thanks @lithomas1 |
closes #121
The min version for numpy on aarch should be 1.19.1 I think(otherwise tests fail).
Was not caught in #141 because Travis CI doesn't run on PRs.