Improve game reproducer

Author: Nihisil

doc/reproducer.md

@@ -1,44 +1,133 @@
-## Round reproducer
+# Game reproducer
 
 We built the way to reproduce already played round. 
-This is really helpful when you want to reproduce table state and fix bot bad behaviour.
+
+This is really helpful when you want to reproduce table state and fix bot incorrect behaviour.
 
 There are two options to do it.
 
-### Reproduce from tenhou log link
+## Getting game meta information
 
-First you need to do dry run of the reproducer with command:
+It will be easier to find the round number to reproduce if you check the game meta-information first:
 
+Command:
+```bash
+python reproducer.py --log 2020102008gm-0001-7994-9438a8f4 --meta
 ```
-python reproducer.py -o "http://tenhou.net/0/?log=2017041516gm-0089-0000-23b4752d&tw=3&ts=2" -d
-```
-
-It will print all available tags in the round. For example we want to stop before 
-discard tile to other player ron, in given example we had to chose `<W59/>` tag as a stop tag.
 
-Next command will be:
-
-```
-python reproducer.py -o "http://tenhou.net/0/?log=2017041516gm-0089-0000-23b4752d&tw=3&ts=2" -t "<W59/>"
+Output:
+```json
+{
+  "players": [
+    {
+      "seat": 0,
+      "name": "Wanjirou",
+      "rank": "新人"
+    },
+    {
+      "seat": 1,
+      "name": "Kaavi",
+      "rank": "新人"
+    },
+    {
+      "seat": 2,
+      "name": "Xenia",
+      "rank": "新人"
+    },
+    {
+      "seat": 3,
+      "name": "Ichihime",
+      "rank": "新人"
+    }
+  ],
+  "game_rounds": [
+    {
+      "wind": 0,
+      "honba": 0,
+      "round_start_scores": [
+        250,
+        250,
+        250,
+        250
+      ]
+    },
+    {
+      "wind": 1,
+      "honba": 1,
+      "round_start_scores": [
+        235,
+        235,
+        265,
+        265
+      ]
+    },
+    {
+      "wind": 1,
+      "honba": 2,
+      "round_start_scores": [
+        221,
+        277,
+        251,
+        251
+      ]
+    },
+    {
+      "wind": 1,
+      "honba": 3,
+      "round_start_scores": [
+        221,
+        298,
+        230,
+        251
+      ]
+    },
+    {
+      "wind": 2,
+      "honba": 0,
+      "round_start_scores": [
+        320,
+        255,
+        197,
+        228
+      ]
+    },
+    {
+      "wind": 3,
+      "honba": 0,
+      "round_start_scores": [
+        290,
+        215,
+        137,
+        358
+      ]
+    }
+  ]
+}
 ```
 
-And output:
+From this information player seat and wind number could be useful for the next command run.
 
-```
-Hand: 268m28p23456677s + 6p
-Discard: 2m
-```
+## Running the reproducing for the game
 
-After this you can debug bot decisions.
+To reproduce game situation you need to know:
+- log id
+- player seat number or player nickname
+- wind number (1-4 for east, 5-8 for south, 9-12 for west)
+- honba number
+- tile where to stop the game
+- action
 
-### Reproduce from our log
+There are two supported actions for the reproducer:
+- `draw`. Sought tile will be added to the hand, then method `discard_tile()` will be called and after that reproducer will stop.
+- `enemy_discard`. After enemy discard method `try_to_call_meld()` will be called (if possible) and after that reproducer will stop.
 
-Sometimes we had to debug `bot <-> server` communication. For this purpose we built this reproducer.
-
-Just use it with already played game:
+## Examples of usage
 
+```bash
+python reproducer.py --log 2020102008gm-0001-7994-9438a8f4 --player Wanjirou --wind 3 --honba 0 --tile 7p --action enemy_discard
 ```
-python reproducer.py -l d6a5e_2017-04-13\ 09_54_01.log
+
+```bash
+python reproducer.py --log 2020102009gm-0001-7994-5e2f46c0 --player Kaavi --wind 3 --honba 1 --tile 5m --action draw
 ```
 
-It will send to the bot all commands that were send from tenhou in real game.

project/game/ai/discard.py

@@ -55,6 +55,7 @@ def __init__(self, player, tile_to_discard, shanten, waiting, ukeire, wait_to_uk
         self.had_to_be_discarded = False
         self.wait_to_ukeire = wait_to_ukeire
         self.second_level_cost = 0
+        self.average_second_level_cost = 0
 
         self.calculate_value()
 
@@ -73,6 +74,10 @@ def serialize(self):
         }
         if self.ukeire_second:
             data["ukeire2"] = self.ukeire_second
+        if self.had_to_be_saved:
+            data["had_to_be_saved"] = self.had_to_be_saved
+        if self.had_to_be_discarded:
+            data["had_to_be_discarded"] = self.had_to_be_discarded
         return data
 
     def find_tile_in_hand(self, closed_hand):

project/game/ai/hand_builder.py

@@ -20,7 +20,7 @@ def discard_tile(self, tiles, closed_hand, melds):
         selected_tile = self.choose_tile_to_discard(tiles, closed_hand, melds)
         return self.process_discard_option(selected_tile, closed_hand)
 
-    def choose_tile_to_discard(self, tiles, closed_hand, melds):
+    def choose_tile_to_discard(self, tiles, closed_hand, melds, for_open_hand=False):
         """
         Try to find best tile to discard, based on different evaluations
         """

project/game/ai/main.py

@@ -117,7 +117,7 @@ def try_to_call_meld(self, tile_136, is_kamicha_discard):
 
             DecisionsLogger.debug(
                 log.MELD_CALL,
-                "Try to call meld",
+                "We decided to open hand",
                 context=[
                     f"Hand: {self.player.format_hand_for_print(tile_136)}",
                     f"Meld: {meld.serialize()}",

project/game/ai/strategies/main.py

@@ -254,10 +254,15 @@ def _find_best_meld_to_open(self, possible_melds, new_tiles, closed_hand, discar
             meld = MeldPrint()
             meld.type = meld_type
             meld.tiles = sorted(tiles)
-
             melds = self.player.melds + [meld]
 
-            selected_tile = self.player.ai.hand_builder.choose_tile_to_discard(new_tiles, closed_hand_copy, melds)
+            DecisionsLogger.debug(
+                log.MELD_HAND, f"Hand: {self._format_hand_for_print(new_tiles, discarded_tile, melds)}"
+            )
+
+            selected_tile = self.player.ai.hand_builder.choose_tile_to_discard(
+                new_tiles, closed_hand_copy, melds, for_open_hand=True
+            )
 
             final_results.append(
                 {
@@ -274,7 +279,12 @@ def _find_best_meld_to_open(self, possible_melds, new_tiles, closed_hand, discar
 
         DecisionsLogger.debug(
             log.MELD_PREPARE,
-            "Options with meld calling (use first one)",
+            "Tiles could be used for open meld",
             context=final_results,
         )
         return final_results[0]
+
+    def _format_hand_for_print(self, tiles, new_tile, melds):
+        hand_string = f"{TilesConverter.to_one_line_string(tiles)} + {TilesConverter.to_one_line_string([new_tile])}"
+        hand_string += " [{}]".format(", ".join([TilesConverter.to_one_line_string(x.tiles) for x in melds]))
+        return hand_string

project/main.py

@@ -18,23 +18,20 @@ def parse_args_and_set_up_settings():
         default=settings.USER_ID,
         help="Tenhou's user id. Example: IDXXXXXXXX-XXXXXXXX. Default is {0}".format(settings.USER_ID),
     )
-
     parser.add_option(
         "-g",
         "--game_type",
         type="string",
         default=settings.GAME_TYPE,
         help="The game type in Tenhou.net. Examples: 1 or 9. Default is {0}".format(settings.GAME_TYPE),
     )
-
     parser.add_option(
         "-l",
         "--lobby",
         type="string",
         default=settings.LOBBY,
         help="Lobby to play. Default is {0}".format(settings.LOBBY),
     )
-
     parser.add_option(
         "-t",
         "--timeout",
@@ -44,9 +41,12 @@ def parse_args_and_set_up_settings():
         "If game is not started in timeout, script will be ended. "
         "Default is {0}".format(settings.WAITING_GAME_TIMEOUT_MINUTES),
     )
-
-    parser.add_option("-c", "--championship", type="string", help="Tournament lobby to play.")
-
+    parser.add_option(
+        "-c",
+        "--championship",
+        type="string",
+        help="Tournament lobby to play.",
+    )
     parser.add_option(
         "-s",
         "--settings",