Better detection of standard preload

[kbrock]

This ends up being an optimization.

Before

First off, includes(:association) has includes_values = [:association], or the uses clause stores an array.

When the framework uses the ActiveRecord::Associations::Preloader, the associations are passed in. If the associations go in via a single association (e.g.: :books), then our Preloader#call patch detects this and calls super right away.

But since includes(:association) stores includes_values as an array (e.g.: [:association]) or uses as an array, we often call the Preloader.call with the array of associations.

This second scenario, creates an extra preloader, then group_by the records creating a second array. It is this extra preloading, grouping, and array that is avoided.

In our tests, this does not happen often, but when running miq tests, this case seemed to happen often.

After

Preload#call will also detect if the association is an array with a single symbol. The extra processing is avoided.

[kbrock]

update:

• fixed trailing whitespace (rubocop)
• swapped order of the operands (rubocop)

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[jrafanie]

Kicking so it tests with rails 7.2

[miq-bot]

Checked commit kbrock@36bbc38 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[jrafanie]

LGTM