Move default filtered events to settings #901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
Fryguy
reviewed
Jan 28, 2025
config/settings.yml
Outdated
Comment on lines
129
to
141
| :ems_openstack_network: | ||
| :blacklisted_event_names: | ||
| - scheduler.run_instance.start | ||
| - scheduler.run_instance.scheduled | ||
| - scheduler.run_instance.end | ||
| :ems_openstack_infra: | ||
| :blacklisted_event_names: | ||
| - identity.authenticate |
There was a problem hiding this comment.
alpha sort
Suggested change
| :ems_openstack_network: | |
| :blacklisted_event_names: | |
| - scheduler.run_instance.start | |
| - scheduler.run_instance.scheduled | |
| - scheduler.run_instance.end | |
| :ems_openstack_infra: | |
| :blacklisted_event_names: | |
| - identity.authenticate | |
| :ems_openstack_infra: | |
| :blacklisted_event_names: | |
| - identity.authenticate | |
| :ems_openstack_network: | |
| :blacklisted_event_names: | |
| - scheduler.run_instance.start | |
| - scheduler.run_instance.scheduled | |
| - scheduler.run_instance.end |
Fryguy
reviewed
Jan 28, 2025
| %w( | ||
| identity.authenticate | ||
| ) | ||
| Settings.ems.ems_openstack_infra.blacklisted_event_names |
There was a problem hiding this comment.
Should this be?
Suggested change
| Settings.ems.ems_openstack_infra.blacklisted_event_names | |
| Settings.ems["ems_#{ems_type}"].blacklisted_event_names |
Asking because the other PRs don't have any code changes in this method, so I suspect you need it here?
Fryguy
reviewed
Jan 28, 2025
| scheduler.run_instance.scheduled | ||
| scheduler.run_instance.end | ||
| ) | ||
| Settings.ems.ems_openstack_network.blacklisted_event_names |
agrare
force-pushed
the
move_default_filtered_events_to_settings
branch
from
340ad0c to
ffc570a
Compare
|
@miq-bot cross-repo-tests ManageIQ/manageiq, ManageIQ/manageiq-providers-ibm_power_vc#126, ManageIQ/manageiq-providers-ibm_cic#56 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Jan 28, 2025
From Pull Request: ManageIQ/manageiq-providers-openstack#901
Fryguy
approved these changes
Jan 28, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependents:
ManageIQ/manageiq#19707