Conversation
jeffibm
force-pushed
the
method-list-dialog
branch
3 times, most recently
from
d7b5716 to
f0b2678
Compare
jeffibm
force-pushed
the
method-list-dialog
branch
from
f0b2678 to
f552314
Compare
| if method_ids.present? | ||
| where(:id => method_ids.split(',').map(&:to_i)) | ||
| else | ||
| where(nil) |
There was a problem hiding this comment.
unsure, but think a simple self would work here.
There was a problem hiding this comment.
Hey @kbrock , Yes, self methods should work here.
I used scope since the query was not that complex.
but, while using the self I was not able to chain it like -
MiqAeMethod
.name_path_search(params[:search])
.domain_search(params[:domain_id])
.selected_methods(params[:ids])
.select("id, relative_path, name")
.order('name')
f552314 to
4da7f18
Compare
|
Tested this with the UI pr: ManageIQ/manageiq-ui-classic#9059 and everything is working good |
jeffibm
force-pushed
the
method-list-dialog
branch
from
4da7f18 to
6b6927e
Compare
|
Checked commit jeffbonson@6b6927e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Hey @kbrock , this PR looks ok. Since it's been open for a while, I have rebased it with Could you please have a look at this when you find time and merge it so that we can get its dependent UI PR merged. |
| validates_inclusion_of :scope, :in => AVAILABLE_SCOPES | ||
|
|
||
| scope :name_path_search, lambda { |search| | ||
| where('name ILIKE ? or relative_path ILIKE ?', "%#{search}%", "%#{search}%") if search.present? |
There was a problem hiding this comment.
| where('name ILIKE ? or relative_path ILIKE ?', "%#{search}%", "%#{search}%") if search.present? | |
| search.present? ? where('name ILIKE ? or relative_path ILIKE ?', "%#{search}%", "%#{search}%") : where({}) |
Alternatively, if we want no results, then you can do : none
Do this across these 3 methods
|
deferring to #23106 Thanks Jeffrey |
5 participants
UPDATE: please see #23106
Related PR - ManageIQ/manageiq-ui-classic#9059
This PR is an RnD work related to the search feature for the selection of the method.
Might be helpful for ManageIQ/manageiq-ui-classic#9047