Update model naming for arrays and refactor #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An array could previously get the same model name as its items and that would result in an exception
TypeError: no implicit conversion of Hash into Integer
because we would attempt to initialize an Array subclass with a Hash of attributes.This PR changes the logic to add
Collection
to the array model name, eg.BooksCollection
so it doesn't conflict with the item model name, eg.Book
.References #52.