Refactor Rotating and add docstrings to Mobject.rotate() and Rotating#4147
Merged
chopan050 merged 7 commits intoManimCommunity:mainfrom Jun 22, 2025
Merged
Refactor Rotating and add docstrings to Mobject.rotate() and Rotating#4147chopan050 merged 7 commits intoManimCommunity:mainfrom
Rotating and add docstrings to Mobject.rotate() and Rotating#4147chopan050 merged 7 commits intoManimCommunity:mainfrom
Conversation
Mobject.rotate and Rotating class
3 tasks
b93569b to
7edb2c3
Compare
58fce57 to
82a186c
Compare
b29cadf to
f800288
Compare
Mobject.rotate and Rotating classMobject.rotate and Refactor Rotating and also add its docstring
chopan050
reviewed
Jun 20, 2025
Contributor
There was a problem hiding this comment.
Thanks! I like the changes in general.
Honestly, I'm not sure whether Rotating should even exist in the first place, as it's very similar to Rotate with a hardcoded rate_func=linear and run_time=5 (now run_time=2). However, that's a discussion for another day.
I do have one specific question:
Mobject.rotate and Refactor Rotating and also add its docstringRotating and add docstrings to Mobject.rotate() and Rotating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Mobject.rotate().Rotating, and add detailed docstring, and adjust Rotating parameter in Example Gallery.Breaking change:
radiansparameter toangleto be consistent with the.rotate()and theRotateclass.Rotatingto be consistent with the.rotate()and theRotateclass.Before:
Rotating(mobject, axis, radians, ...)After :
Rotating(mobject, angle, axis, ...)Links to added or changed documentation pages
rotate: https://manimce--4147.org.readthedocs.build/en/4147/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject.rotateRotating: https://manimce--4147.org.readthedocs.build/en/4147/reference/manim.animation.rotation.Rotating.html#manim.animation.rotation.RotatingReviewer Checklist