Fix transformable label todo #4377
Open
+112
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create TransformableLabel class to properly type transformable labels - Remove type ignore comments by adding proper type annotations - Improve constructor to handle MathTex and string transformation names - Clean kwargs management by separating MathTex constructor args - Update transformable_labels list type annotation - Fix get_transformable_label_movement method to use new attribute names Resolves TODO comment about unclear types in add_transformable_label function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
This PR improves type safety and code quality by:
TransformableLabelclass to handle transformable labels with clear type annotationsget_transformable_label_movementmethod to use the new attribute namesThese changes resolve the TODO comment about unclear types in the
add_transformable_labelfunction and make the code more maintainable and type-safe.Links to added or changed documentation pages
Further Information and Comments
The changes maintain backward compatibility while improving type safety and code clarity.
Reviewer Checklist