Rename SceneFileWriter.save_final_image() to save_image()
#4378
+18
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename SceneFileWriter.save_final_image() to save_image() and fix docstring * fix some type annotations * make docstrings consistent
behackl
approved these changes
Aug 7, 2025
chopan050
requested changes
Aug 11, 2025
github-project-automation
bot
moved this from 👍 To be merged
to 👀 In review
in Dev Board
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
github-project-automation
bot
moved this from 👀 In review
to 👍 To be merged
in Dev Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
SceneFileWriter.save_final_image()tosave_image()and fix docstringfix two type annotations in
scene_file_writer.pymake docstrings consistent
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
save_final_image()was incorrectly named. It is simply saving an image at any point during the scene. It is used incairo_renderer.pyandopengl_renderer.pyto save the last frame ifsave_last_frameis set in the configuration.Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist