Add type annotations to text_mobject.py
#4381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error count: 156
# Conflicts: # manim/camera/camera.py # manim/mobject/svg/svg_mobject.py # manim/mobject/text/code_mobject.py # manim/mobject/text/numbers.py # manim/mobject/text/tex_mobject.py # manim/mobject/types/image_mobject.py # mypy.ini
# Conflicts: # mypy.ini
# Conflicts: # manim/mobject/text/text_mobject.py # mypy.ini
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -120,7 +120,7 @@ | |||
| self.should_center = should_center | |||
| self.svg_height = height | |||
| self.svg_width = width | |||
| self.color = color | |||
| self.color = ManimColor(color) | |||
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
| @@ -110,6 +120,7 @@ | |||
| else: | |||
| mobject_without_dots.add(*(k for k in mobject if k.__class__ != Dot)) | |||
| if iscode: | |||
| assert isinstance(code, Code) | |||
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
henrikmidtiby
commented
Aug 8, 2025
Comment on lines
-647
to
-673
| @deprecated( | ||
| since="v0.14.0", | ||
| until="v0.15.0", | ||
| message="This was internal function, you shouldn't be using it anyway.", | ||
| ) | ||
| def _set_color_by_t2c(self, t2c=None): | ||
| """Sets color for specified strings.""" | ||
| t2c = t2c if t2c else self.t2c | ||
| for word, color in list(t2c.items()): | ||
| for start, end in self._find_indexes(word, self.text): | ||
| self.chars[start:end].set_color(color) | ||
|
|
||
| @deprecated( | ||
| since="v0.14.0", | ||
| until="v0.15.0", | ||
| message="This was internal function, you shouldn't be using it anyway.", | ||
| ) | ||
| def _set_color_by_t2g(self, t2g=None): | ||
| """Sets gradient colors for specified | ||
| strings. Behaves similarly to ``set_color_by_t2c``. | ||
| """ | ||
| t2g = t2g if t2g else self.t2g | ||
| for word, gradient in list(t2g.items()): | ||
| for start, end in self._find_indexes(word, self.text): | ||
| self.chars[start:end].set_color_by_gradient(*gradient) | ||
|
|
||
| def _text2hash(self, color: ManimColor): |
There was a problem hiding this comment.
I have removed this part of the code that was marked as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Reviewer Checklist