Prevent mutation of about_point views in apply_points_function_about_point Fixes #4445 #4478
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds regression tests for issue ManimCommunity#4445 where using get_vertices()[0] as about_point in transformation methods would cause incorrect results due to numpy array view mutation. Tests added: - test_rotate_about_vertex_view - test_scale_about_vertex_view - test_stretch_about_vertex_view - test_apply_matrix_about_vertex_view - test_opengl_rotate_about_vertex_view (OpenGL was not affected by the bug) Related to ManimCommunity#4445
When about_point parameter receives a numpy array view (e.g., from get_vertices()[0]), the in-place operation `mob.points -= about_point` would mutate the view, corrupting the transformation calculation. This fix copies about_point before using it to prevent view mutation. The OpenGL renderer was not affected by this bug because it uses `arr - about_point` (creates temporary) instead of `arr -= about_point` (mutates in-place). Fixes ManimCommunity#4445
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes issue #4445.
Fix
about_pointview mutation inapply_points_function_about_pointWhen about_point parameter receives a numpy array view (e.g., from
get_vertices()[0]), the in-place operation
mob.points -= about_pointwould mutate the view, corrupting the transformation calculation.
This fix copies
about_pointbefore using it to prevent view mutationMotivation and Explanation: Why and how do your changes improve the library?
Bugfix.
Links to added or changed documentation pages
Not applicable
Further Information and Comments
Not applicable.
Reviewer Checklist