remove on_step

MannLabs · May 24, 2024 · f2139e1 · f2139e1
1 parent 4a4c03d
commit f2139e1
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/sparcscore/ml/plmodels.py b/src/sparcscore/ml/plmodels.py
@@ -211,8 +211,8 @@ def training_step(self, batch):
         # accuracy metrics for regression???
 
         self.log('loss/train', loss, on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mse/train', self.mse(output, target), on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mae/train', self.mae(output, target), on_step=False, on_epoch=True, prog_bar=True)
+        self.log('mse/train', self.mse(output, target), on_epoch=True, prog_bar=True)
+        self.log('mae/train', self.mae(output, target), on_epoch=True, prog_bar=True)
 
         return {'loss': loss, 'predictions': output, 'targets': target}
 
@@ -225,8 +225,8 @@ def validation_step(self, batch):
          # accuracy metrics for regression???
 
         self.log('loss/val', loss, on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mse/val', self.mse(output, target), on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mae/val', self.mae(output, target), on_step=False, on_epoch=True, prog_bar=True)
+        self.log('mse/val', self.mse(output, target), on_epoch=True, prog_bar=True)
+        self.log('mae/val', self.mae(output, target), on_epoch=True, prog_bar=True)
 
         return {'loss': loss, 'predictions': output, 'targets': target}
 
@@ -239,8 +239,8 @@ def test_step(self, batch):
          # accuracy metrics for regression???
 
         self.log('loss/test', loss, on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mse/test', self.mse(output, target), on_step=False, on_epoch=True, prog_bar=True)
-        self.log('mae/test', self.mae(output, target), on_step=False, on_epoch=True, prog_bar=True)
+        self.log('mse/test', self.mse(output, target), on_epoch=True, prog_bar=True)
+        self.log('mae/test', self.mae(output, target), on_epoch=True, prog_bar=True)
 
         return {'loss': loss, 'predictions': output, 'targets': target}